Skip to content

✨ Add zipping celery task which returns a download link instead of a path #8089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 15, 2025
Merged

✨ Add zipping celery task which returns a download link instead of a path #8089

merged 16 commits into from
Jul 15, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 10, 2025 •
edited
Loading

What do these changes do?

  • In order to return the logs from all computational nodes of a project via the function section of the api-server this PR adds a variant of the zipping celery task in storage which returns a download link rather than the path to the zip.
  • This endpoint will be exposed via the functions api in the api-server in ✨👽️ Add log zip endpoints in api-server #8056

Related issue/s

How to test

make devenv && source .venv/bin/activate
cd services/storage
make install-dev
python -m pytest tests/unit/test_rpc_handlers_simcore_s3.py

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this Jul 10, 2025
@bisgaard-itis bisgaard-itis added a:storage issue related to storage service Meta-modeling labels Jul 10, 2025
@bisgaard-itis bisgaard-itis added this to the Engage milestone Jul 10, 2025
@codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.09%. Comparing base (359ff33) to head (b2ddc34).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8089      +/-   ##
==========================================
- Coverage   88.26%   88.09%   -0.18%     
==========================================
  Files        1825     1458     -367     
  Lines       69880    60046    -9834     
  Branches     1272      634     -638     
==========================================
- Hits        61679    52896    -8783     
+ Misses       7826     6930     -896     
+ Partials      375      220     -155
Flag Coverage Δ
integrationtests 64.28% <ø> (-0.07%) ⬇️
unittests 86.43% <94.11%> (-0.40%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 71.75% <0.00%> (-0.02%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.05% <ø> (-0.06%) ⬇️
agent 93.81% <ø> (ø)
api_server 92.85% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.23% <ø> (+0.09%) ⬆️
director_v2 90.90% <ø> (-0.16%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.05% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.44% <ø> (+0.26%) ⬆️
storage 86.52% <100.00%> (∅)
webclient ∅ <ø> (∅)
webserver 88.46% <ø> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359ff33...b2ddc34. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis marked this pull request as ready for review July 11, 2025 04:29
@bisgaard-itis bisgaard-itis changed the title ✨ Add zipping endpoint to return download link ✨ Add zipping celery task which returns a download link instead of a path Jul 11, 2025
pcrespov
pcrespov approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg reviewed Jul 14, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks just a question in the comments.

@bisgaard-itis bisgaard-itis requested review from GitHK and sanderegg July 15, 2025 07:18
sanderegg
sanderegg approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

GitHK
GitHK approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with it

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 15, 2025 09:55
@bisgaard-itis
Copy link
Contributor Author

bisgaard-itis commented Jul 15, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@bisgaard-itis bisgaard-itis added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 15, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bisgaard-itis bisgaard-itis merged commit 2699607 into ITISFoundation:master Jul 15, 2025
148 of 150 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@wvangeit wvangeit Awaiting requested review from wvangeit

@JavierGOrdonnez JavierGOrdonnez Awaiting requested review from JavierGOrdonnez

Assignees

@bisgaard-itis bisgaard-itis

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:storage issue related to storage service Meta-modeling

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

5 participants

@bisgaard-itis @GitHK @pcrespov @sanderegg @matusdrobuliak66